Fix regression with HasImport/HasExample data fields, and (finally) document template data fields
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2022 14:11
|
Should a similar change be made to the provider and data source template rendering fields and is there a way to unit test this? |
|
We totally need unit tests and regression tests for this stuff :( |
|
I'm adding the same fix to the Provider section too. The data struct for Resource and Data Sources is the same: yet another thing that should be refactored. |
|
gah, of course 🤦 thanks for finding this @detro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from #155: unfortunately the logic didn't check that the file where an example/import was expected, actually existed.
Additionally, given I had to spend time figuring out a bit more how those data fields are populated, I caught the opportunity to finally document the data fields.
As a bonus, I added 3 template functions that were very low hanging fruits:
lower,upperandtitle.